This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Fixed HTML Injection #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieSlome
requested review from
Mik317 and
toufik-airane
and removed request for
toufik-airane and
Mik317
|
Congratulations mufeedvh - your fix has been selected! 馃帀 Thanks for being part of the community & helping secure the world's open source code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搳 Metadata *
Bounty URL: https://www.huntr.dev/bounties/1-npm-jquery-confirm
鈿欙笍 Description *
The project
jquery-confirmadds classes to HTML elements without any validation causing an HTML Injection.馃捇 Technical Description *
The code dynamically creates an HTML element for the
setIconandcloseIconClassactions and adds classes directly to the elements making it vulnerable to an HTML Injection Vulnerability.The implementation should not be like this and sanitizing/escaping the input class is also not the way as there is a dedicated function in JQuery to do just what we want ==
addClass().This is also suggested by the reporter of this vulnerability: craftpip#508 (comment).
馃悰 Proof of Concept (PoC) *
馃敟 Proof of Fix (PoF) *
As suggested by the reporter, I implemented the JQuery dedicated function
addClass()to add class to the particular dynamically created element completely preventing any bypasses possible.馃憤 User Acceptance Testing (UAT)
Just added a JQuery function on a JQuery project. 馃槈