Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Improve detection of configured Besu instance #14

Closed
aldoborrero opened this issue Apr 29, 2020 · 0 comments · Fixed by #15
Closed

Improve detection of configured Besu instance #14

aldoborrero opened this issue Apr 29, 2020 · 0 comments · Fixed by #15
Assignees
@aldoborrero
Labels
Priority: High Size: Atomic An atomic piece of work with a single associated PR Type: Enhancement Improvements or additions

Comments

@aldoborrero
Copy link
Member

Currently, we are detecting different Besu configuration options by resorting to pre-configured environment variables.

In reality, this showcases the current limitation of the plugin system (a thing we should raise to Besu community), meanwhile, I think it's better to resort to reflection in order to obtain current instances so we are not missing neither constructing by hand needed object instances.
@aldoborrero aldoborrero added Priority: High Type: Enhancement Improvements or additions Size: Atomic An atomic piece of work with a single associated PR labels Apr 29, 2020
@aldoborrero aldoborrero self-assigned this Apr 29, 2020
@aldoborrero aldoborrero mentioned this issue Apr 29, 2020
Merged
12 tasks
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aldoborrero aldoborrero

Labels
Priority: High Size: Atomic An atomic piece of work with a single associated PR Type: Enhancement Improvements or additions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: resorted to use reflection to detect better protocolschedule 41north/besu-exflo
1 participant
@aldoborrero