Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataBase protocol과 Article struct 선언 #23

Merged
merged 1 commit into from Apr 28, 2020
Merged

DataBase protocol과 Article struct 선언 #23

merged 1 commit into from Apr 28, 2020

Conversation

dev-jko
Copy link
Contributor

@dev-jko dev-jko commented Apr 27, 2020

그리고 테스트용으로 쓸 디비 구현체

@dev-jko
DataBase protocol과 Article struct 선언
2f40826 
그리고 테스트용으로 쓸 디비 구현체
@dev-jko dev-jko requested a review from robolovo April 27, 2020 13:25
@dev-jko dev-jko self-assigned this Apr 27, 2020
@dev-jko dev-jko added this to PR 신청 완료 / 리뷰 대기중 in 칸반보드 via automation Apr 27, 2020
@dev-jko dev-jko linked an issue Apr 27, 2020 that may be closed by this pull request
DB를 Realm에서 Sqlite3로 변경합니다 #21
Closed
robolovo
robolovo approved these changes Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@robolovo robolovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Article 구조체에 저희가 필요한 콘텐츠들이 모두 들어있는 것 확인했고, dataBase 프로토콜 부분도 잘 설계된 것 같습니다. 테스트용으로 써보고 문제가 생기면 그 후에 수정하면 될 것 같습니다! 고생하셨어요!!

칸반보드 automation moved this from PR 신청 완료 / 리뷰 대기중 to 리뷰어 승인완료 / merge 대기중 Apr 28, 2020
@dev-jko dev-jko merged commit d8fddf2 into master Apr 28, 2020
칸반보드 automation moved this from 리뷰어 승인완료 / merge 대기중 to merge 완료 / issue 종결 Apr 28, 2020
@dev-jko dev-jko deleted the feature/database branch April 28, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robolovo robolovo robolovo approved these changes

Assignees

@dev-jko dev-jko

Labels
데이터베이스
Projects
칸반보드
  
merge 완료 / issue 종결
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DB를 Realm에서 Sqlite3로 변경합니다
2 participants
@dev-jko @robolovo