Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Today.Storayboard 구현(2) #25

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Today.Storayboard 구현(2) #25

merged 2 commits into from
Apr 29, 2020

Conversation

365kim
Copy link
Member

@365kim 365kim commented Apr 28, 2020 •
edited
Loading

Today.Storayboard 구현 (#10) 관련
금일 작업분 코드리뷰 요청드립니다

1. setDate() 함수 수정

  • 기능은 그대로이나 viewDidLoad() 간결화하도록 dataAsString을 setDate()로 수정

2. setDisabledMode() / setEnabledMode()함수 추가

  • 텍스트뷰가 비어있을 때 setDisabledMode()
    • 저장버튼 비활성화
    • placeholder 표시
  • 텍스트뷰에 작성한 내용이 있을 때 setEnabledMode()
    • 저장버튼 활성화
    • placeholder 감추기

4. 기타

  • 텍스트뷰의 테두리색을 연하게 하는 것은 아직 코드에 반영하지 않았습니다 (내일 pr)

@365kim 365kim requested a review from robolovo April 28, 2020 08:08
@365kim 365kim self-assigned this Apr 28, 2020
@365kim 365kim added this to PR 신청 완료 / 리뷰 대기중 in 칸반보드 via automation Apr 28, 2020
robolovo
robolovo approved these changes Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@robolovo robolovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 더 간결해지고 보기좋아졌습니다! 깔끔하게 정렬까지.. 고생하셨습니다!!

칸반보드 automation moved this from PR 신청 완료 / 리뷰 대기중 to 리뷰어 승인완료 / merge 대기중 Apr 28, 2020
@365kim 365kim merged commit 88f650c into master Apr 29, 2020
칸반보드 automation moved this from 리뷰어 승인완료 / merge 대기중 to merge 완료 / issue 종결 Apr 29, 2020
@365kim 365kim deleted the feature/today branch April 29, 2020 02:20
@365kim 365kim mentioned this pull request May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robolovo robolovo robolovo approved these changes

Assignees

@365kim 365kim

Labels
뷰컨트롤러 구현
Projects
칸반보드
  
merge 완료 / issue 종결
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@365kim @robolovo