Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/file #47

Merged
merged 3 commits into from May 5, 2020
Merged

Feature/file #47

merged 3 commits into from May 5, 2020

Conversation

dev-jko
Copy link
Contributor

@dev-jko dev-jko commented May 4, 2020

파일 이름을 이용해 이미지를 가져옵니다

리뷰어 배정(PR일 기준)

  • 홀수일 : 재두 > 미혜 > 준서 > 재두 (재두는 미혜의 코드를 리뷰한다)
  • 짝수일 : 재두 < 미혜 < 준서 < 재두 (미혜는 재두의 코드를 리뷰한다)

@dev-jko dev-jko added the 개발 label May 4, 2020
@dev-jko dev-jko requested a review from 365kim May 4, 2020 12:15
@dev-jko dev-jko self-assigned this May 4, 2020
@dev-jko dev-jko added this to PR 신청 완료 / 리뷰 대기중 in 칸반보드 via automation May 4, 2020
@dev-jko dev-jko linked an issue May 4, 2020 that may be closed by this pull request
이미지 파일 불러오기 #46
Closed
@365kim
Copy link
Member

365kim commented May 4, 2020 •
edited

getUIImageFromDocDir() : 로컬에 있는 이미지를 불러오는 함수
getUIImageFromBundle() : 번들은 앱에 포함된 리드온리 이미지를 불러오는 함수
getFileStringFromBundle() : 파일 내용을 가져오는 함수

365kim
365kim requested changes May 4, 2020
View reviewed changes
Copy link
Member

@365kim 365kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 함수명/변수명도 좋지만 굳이 리뷰를 드리자면
함수명을 getFile String FromBundle에서 getFile Contents FromBundle
그 함수 안에있는 변수명을 str 에서 fileContents 로 바꾸는 건 어떨까요?

@365kim 365kim self-requested a review May 4, 2020 14:18
@dev-jko dev-jko requested a review from 365kim May 5, 2020 05:47
@365kim
Copy link
Member

365kim commented May 5, 2020

우선은 피커로만 만들기로 해서 리뷰하지 않고 PR 살려두겠습니다~~

365kim
365kim approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@365kim 365kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머지? 머지!

칸반보드 automation moved this from PR 신청 완료 / 리뷰 대기중 to 리뷰어 승인완료 / merge 대기중 May 5, 2020
@dev-jko dev-jko merged commit 5bfe60d into master May 5, 2020
칸반보드 automation moved this from 리뷰어 승인완료 / merge 대기중 to merge 완료 / issue 종결 May 5, 2020
@dev-jko dev-jko deleted the feature/file branch May 5, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@365kim 365kim 365kim approved these changes

Assignees

@dev-jko dev-jko

Labels
개발
Projects
칸반보드
  
merge 완료 / issue 종결
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

이미지 파일 불러오기
2 participants
@dev-jko @365kim