Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that internal collections can be mapped without annotation #92

Closed
robert-bor opened this issue Oct 30, 2017 · 0 comments
Closed

Comments

@robert-bor
Copy link
Contributor

robert-bor commented Oct 30, 2017

All collections must be mapped with the annotation BeanCollection, either on the source or target side. Make sure that the annotation is no longer required. The most important element to scan for is the collection element type on the target side.

Currently, all fields of BeanCollection are individually passed through the internals of BeanMapper. Why not pass those as a collection itself?

Works together with issue #90

@robert-bor robert-bor changed the title Refactor the way BeanCollection settings are passed within BeanMapper Make sure that internal collections can be mapped without annotation Nov 1, 2017
robert-bor added a commit that referenced this issue Nov 1, 2017
Issue #92. BeanMapper is now capable of determining the collection element type of the target collection by examining the generic type. It will use this type as input for the mapping process. BeanCollection.elementType is no longer a required value. BeanMapper will merge collection information from target and source, giving preference to target information.
robert-bor added a commit to 42BV/beanmapper-spring that referenced this issue Nov 2, 2017
…h AnyToEnumConverter works to create a pre-merge original (ie, MergePair).

See also:
- 42BV/beanmapper#92
- 42BV/beanmapper#97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant