Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal not closing properly #426

Closed
b-chiarini opened this issue Jun 3, 2020 · 1 comment · Fixed by #437
Closed

Modal not closing properly #426

b-chiarini opened this issue Jun 3, 2020 · 1 comment · Fixed by #437

Comments

@b-chiarini
Copy link
Contributor

When closing a modal, opened either by the OpenCloseModal or the ConfirmButton, the modal is not closed properly. Parts of the screen remain grayed out, and the screen itself cannot be scrolled.

The cause of this, is that the modal-open class is not removed from the body element. This issue is fixed in the next version of reactstrap.

@gidomanders
Copy link
Member

gidomanders pushed a commit that referenced this issue Jun 22, 2020
The modal-open class remains on the body tag even after the modal is
closed. This is an issue of the reactstrap library
(reactstrap/reactstrap#1323) which is already
fixed buy not released yet.

Added a temporary work-around to remove the modal-open class when modal
is closed.

Closes #426
gidomanders pushed a commit that referenced this issue Jun 22, 2020
The modal-open class remains on the body tag even after the modal is
closed. This is an issue of the reactstrap library
(reactstrap/reactstrap#1323) which is already
fixed buy not released yet.

Added a temporary work-around to remove the modal-open class when modal
is closed.

Closes #426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants