Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote references and support for both single and double qoutes #75

Merged
merged 3 commits into from Aug 6, 2020

Conversation

gayanper
Copy link
Contributor

This change will add completion from files that are referenced relative to the current working directory like
$ref: 'org.gap.shared.spec.yaml#' where pressing for auto completion will show definitions from org.gap.shared.spec.yaml file.

This change also support auto completion with both " and ' as well.

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2020

CLA assistant check
All committers have signed the CLA.

@ak1394
Copy link
Collaborator

ak1394 commented Aug 1, 2020

Thanks for PR! I didn't notice it, so it was sitting there for a while... I'll merge it next week.

@gayanper
Copy link
Contributor Author

gayanper commented Aug 1, 2020

No problem @ak1394

@ak1394 ak1394 merged commit ca1bf29 into 42Crunch:master Aug 6, 2020
@gayanper gayanper deleted the both_qoutes branch August 16, 2020 18:03
@gayanper
Copy link
Contributor Author

@ak1394 when will this feature be released ?

@ak1394
Copy link
Collaborator

ak1394 commented Sep 1, 2020

Ah, sorry missed your comment once again! It'll be included with the next release, though at the moment we're trying to decide if we should release 3.6 in the next few days or perhaps add some more features and call it 4.0 (but that'll delay the release by a few more weeks). I'll let you know once it's been decided.

@ak1394
Copy link
Collaborator

ak1394 commented Sep 2, 2020

@gayanper your changes has been included in todays release

@gayanper
Copy link
Contributor Author

gayanper commented Sep 3, 2020

Thanks @ak1394

ak1394 added a commit that referenced this pull request Jan 24, 2022
Add support for remote references and support for both single and double qoutes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants