feat(jshint): major jshint improvements

README.md

@@ -9,7 +9,7 @@
 * **NO** support for outdated browsers — *Working for IE users? Too bad.*
 * **NO** pre-install for Google Analytics — *Wanna track people? Do it yourself.*
 * **Livereload** on changes in client / server — *You don't have time to waste.*
-* **JSHint** integration — *Write clean code, for purpose.*
+* **JSHint** & **JSCS** integration — *Write clean code, for purpose.*
 * **Sass** support — *Because CSS is a mess.*
 * **Fast build** — *You do faster? Let's see that.*
 
@@ -57,7 +57,7 @@ Launch client and server tests, using Karma and Mocha, both by default.
 
     gulp control
 
-Validate the app through JSHint.
+Validate the app through [JSHint](http://jshint.com/) and [JSCS](http://jscs.info/).
 
     gulp bump [--major || --minor || --patch]
 

app/templates/#.jscsrc

@@ -0,0 +1,61 @@
+{
+  "disallowEmptyBlocks": true,
+  "disallowKeywords": ["with"],
+  "disallowMixedSpacesAndTabs": true,
+  "disallowMultipleLineBreaks": true,
+  "disallowOperatorBeforeLineBreak": ["+", "."],
+  "disallowQuotedKeysInObjects": true,
+  "disallowSpaceAfterObjectKeys": true,
+  "disallowSpaceAfterPrefixUnaryOperators": true,
+  "disallowSpaceBeforePostfixUnaryOperators": true,
+  "disallowSpacesInCallExpression": true,
+  "disallowSpacesInsideParentheses": true,
+  "disallowTrailingComma": true,
+  "disallowTrailingWhitespace": true,
+  "disallowYodaConditions": true,
+  "requireBlocksOnNewline": 1,
+  "requireCommaBeforeLineBreak": true,
+  "requireCurlyBraces": true,
+  "requireDotNotation": true,
+  "requireLineBreakAfterVariableAssignment": true,
+  "requireLineFeedAtFileEnd": true,
+  "requireParenthesesAroundIIFE": true,
+  "requireSpaceAfterBinaryOperators": true,
+  "requireSpaceAfterKeywords": true,
+  "requireSpaceAfterLineComment": true,
+  "requireSpaceBeforeBinaryOperators": true,
+  "requireSpaceBeforeBlockStatements": true,
+  "requireSpaceBeforeKeywords": [
+      "else",
+      "while",
+      "catch"
+  ],
+  "requireSpaceBeforeObjectValues": true,
+  "requireSpaceBetweenArguments": true,
+  "requireSpacesInAnonymousFunctionExpression": {
+    "beforeOpeningRoundBrace": true,
+    "beforeOpeningCurlyBrace": true
+  },
+  "requireSpacesInConditionalExpression": true,
+  "requireSpacesInForStatement": true,
+  "requireSpacesInFunctionDeclaration": {
+    "beforeOpeningRoundBrace": true,
+    "beforeOpeningCurlyBrace": true
+  },
+  "requireSpacesInFunctionExpression": {
+    "beforeOpeningRoundBrace": true,
+    "beforeOpeningCurlyBrace": true
+  },
+  "requireSpacesInFunction": {
+    "beforeOpeningRoundBrace": true,
+    "beforeOpeningCurlyBrace": true
+  },
+  "requireSpacesInNamedFunctionExpression": {
+    "beforeOpeningRoundBrace": true,
+    "beforeOpeningCurlyBrace": true
+  },
+  "requireSpacesInsideObjectBrackets": "all",
+  "validateIndentation": 2,
+  "validateParameterSeparator": ", ",
+  "validateQuoteMarks": "'"
+}

app/templates/#.jshintrc

@@ -0,0 +1,15 @@
+{
+  "bitwise": true,
+  "eqeqeq": true,
+  "forin": true,
+  "freeze": true,
+  "globalstrict": true,
+  "latedef": true,
+  "laxbreak": true,
+  "maxdepth": 3,
+  "nonbsp": true,
+  "nonew": false,
+  "strict": true,
+  "undef": true,
+  "unused": true
+}

app/templates/client/.jshintrc

@@ -0,0 +1,19 @@
+{
+  "browser": true,
+  "globals": {
+    "angular": true,
+    "browser": true,
+    "element": true,
+    "by": true,
+    "module": true,
+    "console": true,
+    "it": true,
+    "describe": true,
+    "inject": true,
+    "expect": true,
+    "alert": true,
+    "afterEach": true,
+    "beforeEach": true<% if (filters.sockets) { %>,
+    "io" : true<% } %>
+  }
+}

app/templates/gulpfile.js

@@ -7,6 +7,8 @@ var bowerFiles = require('main-bower-files');
 var runSequence = require('run-sequence');
 var sq = require('streamqueue');
 var path = require('path');
+var async = require('async');
+var _ = require('lodash');
 var fs = require('fs');
 var karma = require('karma').server;
 var $ = require('gulp-load-plugins')();
@@ -128,14 +130,35 @@ gulp.task('watch', ['inject'], function () {
 /**
  * Control things
  */
-gulp.task('control', function () {
-  return gulp.src([
-    'client/**/**/*.js',
-    'server/**/**/*.js',
-    '!client/bower_components/**'
-  ])
-    .pipe($.jshint())
-    .pipe($.jshint.reporter('default'));
+gulp.task('control', function (done) {
+
+  function getConfig (file) {
+    return _.merge(
+      JSON.parse(fs.readFileSync('./.jshintrc', 'utf-8')),
+      JSON.parse(fs.readFileSync(file, 'utf-8'))
+    );
+  }
+
+  function control (name, paths, conf) {
+    return function (done) {
+      gulp.src(paths)
+        .pipe($.jshint(conf))
+        .pipe($.jshint.reporter('jshint-stylish'))
+        .on('finish', function () {
+          gulp.src(paths)
+            .pipe($.jscs())
+            .on('error', function () {})
+            .pipe($.jscsStylish())
+            .on('end', done);
+        });
+    };
+  }
+
+  async.series([
+    control('client', ['client/**/*.js', '!client/bower_components/**'], getConfig('./client/.jshintrc')),
+    control('server', ['server/**/*.js'], getConfig('./server/.jshintrc'))
+  ], done);
+
 });
 
 

app/templates/package.json

@@ -10,6 +10,8 @@
     "gulp-concat": "^2.4.3",
     "gulp-git": "^1.0.0",
     "gulp-inject": "^1.1.1",
+    "gulp-jscs": "^1.4.0",
+    "gulp-jscs-stylish": "1.0.0",
     "gulp-jshint": "^1.9.1",
     "gulp-livereload": "^3.6.0",
     "gulp-load-plugins": "^0.8.0",
@@ -28,6 +30,7 @@
     "gulp-util": "^3.0.2",
     "gulp-wait": "^0.0.2",
     "gulp-watch": "^4.1.0",
+    "jshint-stylish": "^1.0.1",
     "karma": "^0.12.31",
     "karma-jasmine": "^0.3.5",
     "karma-ng-html2js-preprocessor": "^0.1.2",
@@ -37,6 +40,7 @@
     "streamqueue": "^0.1.2"
   },
   "dependencies": {
+    "async": "^0.9.0",
     "body-parser": "^1.11.0",
     "chalk": "^1.0.0",<% if (filters.auth) { %>
     "composable-middleware": "^0.3.0",<% } %>

app/templates/server/.jshintrc

@@ -0,0 +1,9 @@
+{
+  "node": true,
+  "globals": {
+    "describe": true,
+    "it": true,
+    "afterEach": true,
+    "beforeEach": true
+  }
+}