Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: formatting feature for postgresql query #145

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

42atomys
Copy link
Owner

Relative Issues: Resolve #106

Describe the pull request
This pull request introduces a new feature: a formatting function for PostgreSQL queries. This feature is designed to improve the readability and maintainability of SQL queries by automatically applying consistent formatting rules. The objective of this feature is to help developers write clearer, more understandable SQL queries, making the code easier to read, understand, and debug. By introducing this formatting feature, we aim to enhance developer productivity and the overall quality of our codebase.

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

pkg/formatting/functions.go Outdated Show resolved Hide resolved
pkg/formatting/functions.go Fixed Show fixed Hide fixed
pkg/storage/postgres/postgres.go Fixed Show fixed Hide fixed
@42atomys 42atomys marked this pull request as draft June 30, 2023 07:47
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 91.37% and project coverage change: -0.67 ⚠️

Comparison is base (ec2d22d) 95.16% compared to head (095300d) 94.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   95.16%   94.49%   -0.67%     
==========================================
  Files          22       22              
  Lines        1302     1363      +61     
==========================================
+ Hits         1239     1288      +49     
- Misses         44       51       +7     
- Partials       19       24       +5     
Impacted Files Coverage Δ
pkg/storage/redis/redis.go 90.00% <66.66%> (-10.00%) ⬇️
pkg/storage/postgres/postgres.go 79.31% <80.48%> (-7.06%) ⬇️
internal/server/v1alpha1/handlers.go 93.68% <94.11%> (+0.50%) ⬆️
pkg/formatting/formatter.go 100.00% <100.00%> (ø)
pkg/storage/rabbitmq/rabbitmq.go 82.05% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@42atomys 42atomys marked this pull request as ready for review June 30, 2023 11:55
@42atomys 42atomys merged commit e2cbb72 into main Jun 30, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allow construction of postgres request like formatting module
2 participants