Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands by asset DTOs #25

Closed
wants to merge 1 commit into from
Closed

Conversation

boricj
Copy link
Contributor

@boricj boricj commented Sep 28, 2020

Needed for requesting list of assets supporting a particular power action.

Copy link
Contributor

@perrettecl perrettecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be inside asset source code and not here. @stark-dev could you take a look ?

@stark-dev
Copy link
Contributor

I think this should be inside asset source code and not here. @stark-dev could you take a look ?

Not sure if this is intended to query directly fty-nut or existing assets. Currently I don't think we have a way to get the commands supported by an asset in fty-asset, is it something we should add?

@boricj
Copy link
Contributor Author

boricj commented Sep 29, 2020

Everything related to NUT commands is handled by the agent fty-nut-command. Similarly, IT actions on IT assets are handled by EMC4J2. fty-asset really has no concept of actions and no component in the system has a global overview of asset actions.

Folding all of this inside a centralized action provider mechanism is going to require lots of design and work, as actions provided by dedicated components (fty-nut-command, EMC4J2...) will need to be both registered for enumeration and delegated for execution, not counting the fact that this would be a cross-team endeavor. I'm not going to to that for now, so I'm just going to extend this particular provider of actions to address that particular use case instead.

@stark-dev
Copy link
Contributor

stark-dev commented Sep 29, 2020

Everything related to NUT commands is handled by the agent fty-nut-command. Similarly, IT actions on IT assets are handled by EMC4J2. fty-asset really has no concept of actions and no component in the system has a global overview of asset actions.

Folding all of this inside a centralized action provider mechanism is going to require lots of design and work, as actions provided by dedicated components (fty-nut-command, EMC4J2...) will need to be both registered for enumeration and delegated for execution, not counting the fact that this would be a cross-team endeavor. I'm not going to to that for now, so I'm just going to extend this particular provider of actions to address that particular use case instead.

Thanks, with @perrettecl we were discussing the possibility of adding an advanced filter for listing assets based on some of their properties, but it is not necessarily related, just wondering if it could be merged in some way

@boricj
Copy link
Contributor Author

boricj commented Oct 6, 2020

Another technical solution has been selected.

@boricj boricj closed this Oct 6, 2020
@perrettecl perrettecl deleted the feature/getCommandsByAsset branch November 23, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants