Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix to Discord replies buggy since version 1.2.4 #1780

Closed
BrotherIAmPinnedHere opened this issue Mar 30, 2022 · 3 comments
Closed

Matrix to Discord replies buggy since version 1.2.4 #1780

BrotherIAmPinnedHere opened this issue Mar 30, 2022 · 3 comments
Labels

Comments

@BrotherIAmPinnedHere
Copy link

Describe the bug
As of version 1.2.4, replies seem thoroughly broken when done on Matrix and bridged to Discord. Ordinarily, replies look something like this:

image (ignore the first two 'test's)

After version 1.2.4, the quote without preservethreading: true ends up coming through as

[thread:]
test

With preservethreading: true, replies will show up correctly on Discord, but puppeting will break and they will appear to have come from the bridge bot its self rather than the user who made the comments.
(usernames removed as the users did not consent to being posted)

image

To Reproduce
Uncertain. Running Ubuntu 18.04. There does not appear to be anything untoward in the SystemD logs for Matterbridge and I didn't see anything strange when debugging. I am using replacemessage to prevent abuse of pings through the bridge and a general media upload limit of 8 MB , but other than that basically everything is default.

@42wim 42wim closed this as completed Mar 31, 2022
@42wim 42wim added discord and removed bug labels Mar 31, 2022
@BrotherIAmPinnedHere
Copy link
Author

BrotherIAmPinnedHere commented Apr 1, 2022

Is there a setting to restore the original reply system after V1.2.4? Seemed to be the best alternative without Discord directly supporting replies.

@42wim
Copy link
Owner

42wim commented Apr 3, 2022

What version are you talking about because 1.2.4 is very old

42wim added a commit that referenced this issue Apr 3, 2022
Sorta regression introduced by 9a8ce9b
which changes the way we get replies of matrix.

This causes issues like #1780
We "fix" this by mimicking the old behaviour when "PreserveThreading" is
disabled.
42wim added a commit that referenced this issue Apr 3, 2022
Sorta regression introduced by 9a8ce9b
which changes the way we get replies of matrix.

This causes issues like #1780
We "fix" this by mimicking the old behaviour when "PreserveThreading" is
disabled.
42wim added a commit that referenced this issue May 1, 2022
Matrix quotes replies and as of matterbridge 1.24.0 we strip those as this causes
issues with bridges support threading and have PreserveThreading enabled.

Introduced via 9a8ce9b

But if you for example use mattermost or discord with webhooks you'll need to enable
this if you want something that looks like a reply from matrix.
See issues:
- #1819
- #1780
42wim added a commit that referenced this issue May 1, 2022
Matrix quotes replies and as of matterbridge 1.24.0 we strip those as this causes
issues with bridges support threading and have PreserveThreading enabled.

Introduced via 9a8ce9b

But if you for example use mattermost or discord with webhooks you'll need to enable
this if you want something that looks like a reply from matrix.
See issues:
- #1819
- #1780
42wim added a commit that referenced this issue May 6, 2022
Matrix quotes replies and as of matterbridge 1.24.0 we strip those as this causes
issues with bridges support threading and have PreserveThreading enabled.

Introduced via 9a8ce9b

But if you for example use mattermost or discord with webhooks you'll need to enable
this if you want something that looks like a reply from matrix.
See issues:
- #1819
- #1780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants