Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown markup characters in irc nicknames are not escaped when bridged to discord #285

Closed
illwieckz opened this issue Oct 25, 2017 · 1 comment
Labels
Projects

Comments

@illwieckz
Copy link

illwieckz commented Oct 25, 2017

Which version of matterbridge are you using?

version: 0.12.1-dev

Please describe the expected behavior.

Using characters known to be markdown control characters in irc nickname must not be parsed as markdown control character by discord.

Please describe the actual behavior.

Using a character known to be a markdown control character in irc nickname makes discord parsing the nickname.

Any steps to reproduce the behavior?

Join an irc channel bridged to a discord one, and use this nickname:

`test

Then types this message in irc channel:

this is code`

You get that on discord side:

<test> this is code

You must get that:

<`test> this is code

I guess any character known to be a markdown markup one must be escaped when found in irc nickname prior to be sent to discord.

@42wim 42wim added the bug label Oct 26, 2017
@42wim 42wim added this to To Do in v1.4 Oct 26, 2017
@42wim 42wim closed this as completed in 41aa8ad Oct 26, 2017
@42wim
Copy link
Owner

42wim commented Oct 26, 2017

Fixed this by adding a new StripNick parameter, which strips every non-alphanumerical character.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v1.4
Done
Development

No branches or pull requests

2 participants