Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround IRC rate limit #40

Closed
ishitatsuyuki opened this issue Oct 3, 2016 · 6 comments
Closed

Workaround IRC rate limit #40

ishitatsuyuki opened this issue Oct 3, 2016 · 6 comments
Labels
enhancement New feature or request

Comments

@ishitatsuyuki
Copy link
Contributor

Markdown users tend to paste multiline formatted code, which is less often in IRC. Forwading such message in batch will cause a kick with flooding, so it's better to have some slow down to workaround it.

@42wim 42wim added the enhancement New feature or request label Oct 8, 2016
@jleclanche
Copy link

@42wim What gitter-irc-bot did to work around this was a View full message: <link> with a link that would directly send users to the upstream gitter message. I think it's super neat, although not necessarily available on all protocols.

@jleclanche
Copy link

@42wim if this isn't going to be resolved any time soon, would you be willing to add a "max lines" setting for irc that we can set to prevent spam? This would clip the message, appending <message clipped> to the end of the last line.

I'm asking because it's possible for somebody to inadvertently send hundreds of lines at once without realizing the impact on mirrored channels.

42wim added a commit that referenced this issue Nov 1, 2016
@42wim
Copy link
Owner

42wim commented Nov 1, 2016

I've added support for 2 parameters against IRC flooding.

  • MessageQueue: maximum amount of messages to hold in queue. (default 30)
  • MessageDelay: in milliseconds delay between each message. (default 1300)

@42wim 42wim closed this as completed Nov 5, 2016
@Gummikavalier
Copy link

@42wim Hi! Would it be possible to have a max limit for one line messages, preferably with an aforementioned <message clipped> or preferably custom message, in the style of <Read more at xxxxx>?

We have a problem that when someone pastes very long one line paragraph, it causes excess flood and kicks matterbridge bot out of the IRC server.

When this happens Matterbridge does get back online, but it doesn't rejoin the channel. Fixing this would be helpful too, of course. However a simple message about clipping would be tidier and more informative to people that the message was cut in the first place.

@42wim
Copy link
Owner

42wim commented May 26, 2017

@Gummikavalier Sure I'll look into this, but could you open an separate issue for this ?

@Gummikavalier
Copy link

@42wim Thanks! I opened a new issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants