Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack → Mattermost custom avatars not synced (excepted for mine) #472

Closed
ArchangeGabriel opened this issue Jul 30, 2018 · 4 comments
Closed
Labels
Milestone

Comments

@ArchangeGabriel
Copy link

Describe the bug
This is a follow up of #454. Basically, users sending messages from Slack to Mattermost fall into one of the three following categories:

  1. They use a default avatar from Slack, in which case this one is properly displayed on mattermost side.
  2. Me, using a custom avatar on Slack which is properly displayed on Mattermost.
  3. Anyone else using a custom avatar, which is replaced by the default bridge logo.

To Reproduce
Have anyone excepted myself post on the Slack side.

Expected behavior
Custom avatars should be displayed properly on Mattermost side, not only mine.

Screenshots/debug logs
Logs: see #454 (comment), #454 (comment) and #454 (comment).

Environment (please complete the following information):

  • OS: Arch Linux
  • Matterbridge version: 1.11.0 + fa0c402

Additional context
Config: #454 (comment)

As well as a new addition to gateways:

[[gateway]]
name="gateway_test"
enable=true

    [[gateway.inout]]
    account="mattermost.<redacted>"
    channel="test"

    [[gateway.inout]]
    account="slack.<redacted>"
    channel="test"

Tests have been made in both the samechannel gateway and the gateway_test.

@42wim 42wim added this to the 1.11.1 milestone Aug 6, 2018
@42wim 42wim added the bug label Aug 6, 2018
@42wim 42wim closed this as completed in d71850c Aug 6, 2018
@42wim
Copy link
Owner

42wim commented Aug 6, 2018

This should be fixed in master now, try a dev binary from https://bintray.com/42wim/nightly/Matterbridge/_latestVersion or rebuild from source.

If still an issue, please reopen!

@ArchangeGabriel
Copy link
Author

That commit fixed, thanks! You’re doing a stellar job. :)

I’m ready to update to 1.11.1 too, just missing the PGP signature on the tarball. ;)

@42wim
Copy link
Owner

42wim commented Aug 6, 2018

Thanks ;)
The signature should be there now

@ArchangeGabriel
Copy link
Author

ArchangeGabriel commented Aug 6, 2018

On a side note, thanks to you I’ve figured out why it worked for me and not the others, and this helped me fix another issue: under Mattermost my Slack username was shown, while other people have their normal name. But that’s because they have a DisplayName while I was only having a FullName. Added a display name for myself and now everything is OK.

Since you’ve also fixed #452 in that release, this is now looking very pretty.

#191 would make this awesome, #474 (and the reverse way) would be the cherry on the top!

Keep up the great work! :D

zeridon pushed a commit to zeridon/matterbridge that referenced this issue Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants