Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telegram] panic: runtime error: slice bounds out of range #857

Closed
ValdikSS opened this issue Jul 6, 2019 · 1 comment
Closed

[Telegram] panic: runtime error: slice bounds out of range #857

ValdikSS opened this issue Jul 6, 2019 · 1 comment
Labels
bug

Comments

@ValdikSS
Copy link
Contributor

ValdikSS commented Jul 6, 2019

Describe the bug
Matterbridge crashes with the following error:

panic: runtime error: slice bounds out of range

goroutine 386 [running]:
github.com/42wim/matterbridge/bridge/telegram.(*Btelegram).handleEntities(0xc000458420, 0xc0004d1e20, 0xc000628780)
        /go/src/github.com/42wim/matterbridge/bridge/telegram/handlers.go:378 +0x3b4
github.com/42wim/matterbridge/bridge/telegram.(*Btelegram).handleRecv(0xc000458420, 0xc0007f6cc0)
        /go/src/github.com/42wim/matterbridge/bridge/telegram/handlers.go:153 +0x43c
created by github.com/42wim/matterbridge/bridge/telegram.(*Btelegram).Connect
        /go/src/github.com/42wim/matterbridge/bridge/telegram/telegram.go:46 +0x376

To Reproduce
I don't know how to reproduce it. It happens once in a week.

Environment (please complete the following information):
42wim added a commit that referenced this issue Jul 6, 2019
@42wim
Fix panic by checking slice bounds in handleEntities (telegram). Fixes …
4762597 
…#857

Besides the bound checking, this now also use utf16 as suggested by
go-telegram-bot-api/telegram-bot-api#231
@42wim
Copy link
Owner

42wim commented Jul 6, 2019

Should be fixed in #858
You can try dev binaries with this PR in on https://bintray.com/42wim/nightly/Matterbridge/v1.15.0-11-g4762597#files

@42wim 42wim closed this as completed in 1fb91c6 Jul 8, 2019
@42wim 42wim added the bug label Jul 8, 2019
zeridon pushed a commit to zeridon/matterbridge that referenced this issue Feb 12, 2020
@42wim @zeridon
Fix panic by checking slice bounds in handleEntities (telegram). Fixes …
35b6902 
…42wim#857 (42wim#858)

Besides the bound checking, this now also use utf16 as suggested by
go-telegram-bot-api/telegram-bot-api#231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@42wim @ValdikSS