Add TLSConfig to nctalk #1195
Merged
Add TLSConfig to nctalk #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-kim
force-pushed
the
enh/noid/disable-tls-nctalk
branch
2 times, most recently
from
b50480b
to
243a7cd
Compare
gary-kim
commented
Aug 13, 2020
gary-kim
force-pushed
the
enh/noid/disable-tls-nctalk
branch
from
243a7cd
to
2579141
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Confirmed to be working |
gary-kim
force-pushed
the
enh/noid/disable-tls-nctalk
branch
from
2579141
to
1b0d065
Compare
Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
force-pushed
the
enh/noid/disable-tls-nctalk
branch
from
1b0d065
to
7b9b18e
Compare
|
Code Climate has analyzed commit 7b9b18e and detected 0 issues on this pull request. View more on Code Climate. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to test. Give me a bit to set up an instance with improper SSL config.
Signed-off-by: Gary Kim gary@garykim.dev