Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced gorilla with melody #1205

Merged
merged 2 commits into from Aug 26, 2020
Merged

Conversation

NikkyAI
Copy link
Contributor

@NikkyAI NikkyAI commented Aug 23, 2020

also added websocat command to the matterbridge.tml.sample

@NikkyAI NikkyAI force-pushed the feature/websockets-melody branch 2 times, most recently from 897752c to b0c7b2f Compare August 23, 2020 21:01
@NikkyAI
Copy link
Contributor Author

NikkyAI commented Aug 23, 2020

this does NOT send backlog to the websockets on connection
I plan to add that in a followup PR

api/stream still consumes messages from the buffer
and accessing api/messages will clear the message buffer
... these are things i will modify in followup PRs

websockets do not consume messages as messages are directly sent to the melody router

bridge/api/api.go Outdated Show resolved Hide resolved
bridge/api/api.go Outdated Show resolved Hide resolved
@42wim
Copy link
Owner

42wim commented Aug 24, 2020

some small changes and it can be merged

@42wim 42wim modified the milestones: 1.18.2, 1.18.3 Aug 24, 2020
@codeclimate
Copy link

codeclimate bot commented Aug 25, 2020

Code Climate has analyzed commit e17b7c9 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@NikkyAI
Copy link
Contributor Author

NikkyAI commented Aug 25, 2020

rebased on master and rnamed the requested bits
(also one occurrence where i forgot to return in case of error)

@NikkyAI NikkyAI requested a review from 42wim August 25, 2020 12:29
@42wim 42wim merged commit 27c0254 into 42wim:master Aug 26, 2020
@NikkyAI NikkyAI deleted the feature/websockets-melody branch August 26, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants