Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor guild finding code (discord) #1319

Merged
merged 1 commit into from Dec 3, 2020
Merged

Conversation

qaisjp
Copy link
Collaborator

@qaisjp qaisjp commented Nov 30, 2020

No description provided.

bridge/discord/discord.go Outdated Show resolved Hide resolved
bridge/discord/discord.go Outdated Show resolved Hide resolved
bridge/discord/discord.go Outdated Show resolved Hide resolved
@qaisjp
Copy link
Collaborator Author

qaisjp commented Dec 1, 2020

That package's errors.Wrap function is used frequently in my feature/transmitter branch: master...qaisjp:feature/transmitter.

And this package is actually already pulled in by multiple things we depend on, and this just makes it available inside matterbridge:

matterbridge/go.sum

Lines 665 to 669 in ad95e35

github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pkg/errors v0.8.1 h1:iURUrRGxPUNPdy5/HRSm+Yj6okJ6UtLINN0Q9M4+h3I=
github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=

Do you still want me to eliminate this dependency?

@qaisjp
Copy link
Collaborator Author

qaisjp commented Dec 1, 2020

Hmm, looks like there's a "new" way of wrapping errors: https://blog.golang.org/go1.13-errors

I'll move the code I've written to do what that says, and get rid of github.com/pkg/errors

@42wim
Copy link
Owner

42wim commented Dec 1, 2020

wrt pkg/errors, if you need it you can use it but I think there was no reason to use it here for what you are/were using it for :)

@codeclimate
Copy link

codeclimate bot commented Dec 3, 2020

Code Climate has analyzed commit a66a855 and detected 0 issues on this pull request.

View more on Code Climate.

@42wim 42wim added this to the 1.21.0 milestone Dec 3, 2020
@42wim 42wim merged commit c42167c into master Dec 3, 2020
@42wim 42wim deleted the refactor/guild-finding branch December 3, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants