Add UserName and RealName options for IRC #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows setting custom values for the IRC username/ident and real name (gecos) fields at server registration time with gIRC.
|
Code Climate has analyzed commit 2d7599e and detected 0 issues on this pull request. View more on Code Climate. |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently matterbridge automatically uses its IRC nickname to fill in the username/ident and real name/gecos fields at server registration time. While there's no problem with this, sometimes it's very convenient to set a custom ident and real name that's more apropos to a bot/bridge's purpose, e.g. to allow the person who controls it to provide some short contact information in the bot's /WHOIS info, or some other kind of additional identification.
This just adds
UserNameandRealNameconfig options for IRC to allow customizing those fields. They still default to the bridge's nickname if not specified.(I will admit I'm unsure if those are the best possible names -- they may be a bit too IRC-centric.)