Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mattermost threading #627

Merged
merged 3 commits into from
Jan 9, 2019

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Dec 1, 2018

This is untested, as I don't have access to a mattermost instance.

@codeclimate
Copy link

codeclimate bot commented Dec 1, 2018

Code Climate has analyzed commit 3e39c88 and detected 0 issues on this pull request.

View more on Code Climate.

bridge/slack/helpers.go Outdated Show resolved Hide resolved
@42wim
Copy link
Owner

42wim commented Dec 3, 2018

@patcon thanks for the initiative :-) I'll test asap on an instance

@42wim
Copy link
Owner

42wim commented Dec 8, 2018

Almost works. You need to actually set the ParentID though :)

Add ParentID: message.Post.ParentId, below:

rmsg := &config.Message{
Username: message.Username,
UserID: message.UserID,
Channel: message.Channel,
Text: message.Text,
ID: message.Post.Id,
Extra: make(map[string][]interface{}),
}

@42wim
Copy link
Owner

42wim commented Dec 26, 2018

@patcon are you going to fix this PR with the mattermost issue or should I open a new one for this?

@42wim 42wim force-pushed the master branch 3 times, most recently from 487572a to 426aa33 Compare December 26, 2018 16:27
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

matterclient/messages.go Show resolved Hide resolved
matterclient/messages.go Show resolved Hide resolved
matterclient/messages.go Show resolved Hide resolved
matterclient/messages.go Show resolved Hide resolved
matterclient/messages.go Show resolved Hide resolved
matterclient/messages.go Show resolved Hide resolved
matterclient/messages.go Show resolved Hide resolved
@42wim 42wim self-assigned this Jan 9, 2019
@42wim 42wim merged commit b33b509 into 42wim:master Jan 9, 2019
@patcon patcon deleted the mattermost-threading branch January 10, 2019 00:52
zeridon pushed a commit to zeridon/matterbridge that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants