Sshchat fixes #675

ValdikSS · 2019-01-05T13:33:39Z

The patchset fixes most annoying SSH-Chat problems.

42wim · 2019-01-05T14:42:49Z

Thanks!

patcon · 2019-01-05T21:23:53Z

bridge/sshchat/sshchat.go

@@ -33,7 +33,7 @@ func (b *Bsshchat) Connect() error {
 		b.r = bufio.NewScanner(r)
 		b.r.Scan()
 		b.w = w
-		if _, err := b.w.Write([]byte("/theme mono\r\n")); err != nil {
+		if _, err := b.w.Write([]byte("/theme mono\r\n/quiet\r\n")); err != nil {


totes agree that "quiet" makes sense, @ValdikSS :) you're a hero

just want to flag for later (if interested) that quiet mode messages could perhaps also be dropped in the gateway by tagging these sshchat messages as msg.Event = config.EventJoinLeave on their way into the gateway from sshchat bridge :)

matterbridge/gateway/handlers.go

Lines 148 to 168 in ccd55d2

// ignoreEvent returns true if we need to ignore this event for the specified destination bridge.

func (gw *Gateway) ignoreEvent(event string, dest *bridge.Bridge) bool {

switch event {

case config.EventAvatarDownload:

// Avatar downloads are only relevant for telegram and mattermost for now

if dest.Protocol != "mattermost" && dest.Protocol != "telegram" {

return true

}

case config.EventJoinLeave:

// only relay join/part when configured

if !dest.GetBool("ShowJoinPart") {

return true

}

case config.EventTopicChange:

// only relay topic change when used in some way on other side

if dest.GetBool("ShowTopicChange") && dest.GetBool("SyncTopic") {

return true

}

}

return false

}

* SSH-Chat: set quiet mode to filter joins/quits * SSH-Chat: Trim newlines in the end of relayed messages * SSH-Chat: fix media links * SSH-Chat: do not relay "Rate limiting is in effect" message

ValdikSS added 4 commits January 5, 2019 16:30

SSH-Chat: set quiet mode to filter joins/quits

475e69b

SSH-Chat: Trim newlines in the end of relayed messages

5594bec

SSH-Chat: fix media links

c0b59f0

SSH-Chat: do not relay "Rate limiting is in effect" message

52cfdad

42wim merged commit 7326b9e into 42wim:master Jan 5, 2019

patcon reviewed Jan 5, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sshchat fixes #675

Sshchat fixes #675

ValdikSS commented Jan 5, 2019

42wim commented Jan 5, 2019

patcon Jan 5, 2019

	// ignoreEvent returns true if we need to ignore this event for the specified destination bridge.
	func (gw Gateway) ignoreEvent(event string, dest bridge.Bridge) bool {
	switch event {
	case config.EventAvatarDownload:
	// Avatar downloads are only relevant for telegram and mattermost for now
	if dest.Protocol != "mattermost" && dest.Protocol != "telegram" {
	return true
	}
	case config.EventJoinLeave:
	// only relay join/part when configured
	if !dest.GetBool("ShowJoinPart") {
	return true
	}
	case config.EventTopicChange:
	// only relay topic change when used in some way on other side
	if dest.GetBool("ShowTopicChange") && dest.GetBool("SyncTopic") {
	return true
	}
	}
	return false
	}

Sshchat fixes #675

Sshchat fixes #675

Conversation

ValdikSS commented Jan 5, 2019

42wim commented Jan 5, 2019

patcon Jan 5, 2019

Choose a reason for hiding this comment