Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no result for bundlephobia #7

Open
daKmoR opened this issue Dec 4, 2020 · 4 comments
Open

no result for bundlephobia #7

daKmoR opened this issue Dec 4, 2020 · 4 comments

Comments

@daKmoR
Copy link

daKmoR commented Dec 4, 2020

https://bundlephobia.com/result?p=hanbi

would be nice if it would give a size... so we can "proof" how small it is 🤗

@43081j
Copy link
Owner

43081j commented Dec 4, 2020

Have opened pastelsky/bundlephobia#432 , lets see if they can tell us what the actual error was since the logged one contains no useful information 🙈

I also suspect it'll be larger than it really is, because we have to ship both ESM and CJS. otherwise we end up with fake-ESM (the kind that only works in node)

@micalevisk
Copy link

it's working now

image

@micalevisk
Copy link

@43081j you could add the following badge in the README as well

[![npm bundle size](https://img.shields.io/bundlephobia/minzip/hanbi.svg)](https://www.npmjs.com/package/hanbi)

npm bundle size

@43081j
Copy link
Owner

43081j commented Feb 13, 2022

Awesome :D

It's unfortunate I have to ship a commonjs version. It's literally 2x the actual size because of that. May consider dropping cjs in a major release 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants