Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize timeout tests. Fix twitter timeout. #131

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
3 participants
@peterneyens
Copy link
Member

commented Aug 18, 2017

I generalized the tests which check if a FetchMonadError can timeout a Query.

Before, two tests didn't actually run for both TwitterFuture and Rerunnable, because they were asynchronous and the tests stopped before the results were returned. One of these tests failed for TwitterFuture and Rerunnable.
When a Timout was set for a asynchronous Query it would always time out. Timer.Nil was used to execute the timeouts, which invokes tasks immediately. I changed it to JavaTimer which is based on java.util.Timer (which is already used in the timeout for scala.concurrent.Future).

@codecov-io

This comment has been minimized.

Copy link

commented Aug 18, 2017

Codecov Report

Merging #131 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   78.63%   78.81%   +0.17%     
==========================================
  Files          15       15              
  Lines         323      321       -2     
  Branches        2        2              
==========================================
- Hits          254      253       -1     
+ Misses         69       68       -1
Impacted Files Coverage Δ
twitter/jvm/src/main/scala/TwitterFuture.scala 80% <100%> (-2.36%) ⬇️
monix/shared/src/main/scala/monix.scala 78.57% <0%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49aaecb...2aa7bc8. Read the comment docs.

@peterneyens peterneyens changed the title Generalize timeout tests. Fix twitter timout. Generalize timeout tests. Fix twitter timeout. Aug 18, 2017

@peterneyens peterneyens force-pushed the peter-generalize-timout-tests branch from 67e7f2f to 2aa7bc8 Aug 18, 2017

@peterneyens peterneyens merged commit 8766d50 into master Aug 21, 2017

4 checks passed

codecov/patch 100% of diff hit (target 78.63%)
Details
codecov/project 78.81% (+0.17%) compared to 49aaecb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@peterneyens peterneyens deleted the peter-generalize-timout-tests branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.