Clean up macros; Support reflection #24
Conversation
andyscott
force-pushed
the
feature/reflection
branch
from
c0edce0
to
e2e0d5d
Compare
| )(tpe: Type): Either[Id[String], List[Type]] = | ||
| typeListFoldLeft(nilTpe, consTpe)(tpe)(List.empty[Type])((acc, t) => t :: acc).map(_.reverse) | ||
|
|
||
| final def tlistTypes(tpe: Type): Either[Id[String], List[Type]] = |
There was a problem hiding this comment.
I'd really expect this to use Iota coproducts, but ok, I guess it will do.... 😃
| final def destructCop(tpe: Type): Either[Id[String], CopTypes] = | ||
| tpe.dealias match { | ||
| case TypeRef(_, sym, l :: Nil) if resultType(sym) <:< CopTpe => Right(CopTypes(l)) | ||
| case TypeRef(_, sym, Nil) => destructCop(sym.asType.toType) |
There was a problem hiding this comment.
Do we not have sym.typeSignature assuming this is a TypeSymbol? sym.asType.toType can throw scala.ScalaReflectionException as far as I know.
There was a problem hiding this comment.
I just checked-- .typeSignature gives a different result than .asType.toType, and it causes the tests to fail. I'm going to sort out what the differences are and look at cleaning this up, regardless!
There was a problem hiding this comment.
Hi @andyscott I accept I am wrong here, I just didn't know the API differences.
There was a problem hiding this comment.
The feedback was very welcomed regardless! I didn't know about (or hadn't used) .typeSignature before; now I I'll use it next time I'm poking around.
| final def destructCopK(tpe: Type): Either[Id[String], CopKTypes] = | ||
| tpe.dealias match { | ||
| case TypeRef(_, sym, l :: a :: Nil) if resultType(sym) <:< CopKTpe => Right(CopKTypes(l, a)) | ||
| case TypeRef(_, sym, Nil) => destructCopK(sym.asType.toType) |
There was a problem hiding this comment.
Same as above, this is in effect, tpe.dealias no? I'm not sure what kind of magic unapply does, but I do know weakTypeOf[T].termSymbol.asType.toType blows up.
|
|
||
| import scala.reflect.macros.blackbox.Context | ||
|
|
||
| private[iota] final class TypeListMacros(cc: Context) |
There was a problem hiding this comment.
Weird alignment I think, but I'm not sure if this is your standard scalaFMT and I just have different habits. I would expect:
class A(
..args
) extends Bla {
}
andyscott
force-pushed
the
feature/reflection
branch
from
e2e0d5d
to
dac1959
Compare
No description provided.