Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHException extends Throwable #362

Closed
dcsobral opened this issue Mar 7, 2020 · 3 comments
Closed

GHException extends Throwable #362

dcsobral opened this issue Mar 7, 2020 · 3 comments

Comments

@dcsobral
Copy link
Contributor

dcsobral commented Mar 7, 2020

It should really extend Exception instead, since it's something applications could possibly handle -- as evidenced by the fact it's returned inside a Left instead of being thrown.
@BenFradet
Copy link
Contributor

That sounds sensible to me 👍

@kalexmills
Copy link
Contributor

On the most recent version, it looks like this is now the case. Does this issue need to be closed?

@BenFradet
Copy link
Contributor

mmh it still extends Throwable

BenFradet added a commit that referenced this issue Apr 7, 2020
@BenFradet
Make GHException extend Exception, fixes #362
4215592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dcsobral @BenFradet @kalexmills