Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sealed GithubAPIs prevents extension #392

Closed
dcsobral opened this issue Mar 26, 2020 · 0 comments
Closed

Sealed GithubAPIs prevents extension #392

dcsobral opened this issue Mar 26, 2020 · 0 comments

Comments

@dcsobral
Copy link
Contributor

Though individual languages can be extended, having GithubAPIs be a sealed trait prevents extending it as a way of getting the whole algebra and being able to either use GithubAPIv3 or some other implementation.

In fact, I'd argue that trait GithubAPIs should be part of the algebras, not the modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant