Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify JVM and JS tests #115

Merged
merged 5 commits into from May 4, 2017
Merged

Unify JVM and JS tests #115

merged 5 commits into from May 4, 2017

Conversation

fedefernandez
Copy link
Contributor

Fixes #44

Please @juanpedromoreno could you review? Thanks

@codecov-io
Copy link

codecov-io commented May 4, 2017

Codecov Report

Merging #115 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   87.79%   87.47%   -0.32%     
==========================================
  Files          36       36              
  Lines         516      519       +3     
  Branches        3        3              
==========================================
+ Hits          453      454       +1     
- Misses         63       65       +2
Impacted Files Coverage Δ
...b4s/shared/src/main/scala/github4s/Implicits.scala 33.33% <0%> (-8.34%) ⬇️
...4s/shared/src/main/scala/github4s/api/Issues.scala 76.92% <0%> (+6.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc89d5e...c18216e. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, oustanding work!

giphy 17

@fedefernandez fedefernandez merged commit c38ee4d into master May 4, 2017
@fedefernandez fedefernandez deleted the ff-shared-tests branch May 4, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants