Issues API unit tests #116
Conversation
|
|
I'm not sure what could be the cause. I'll try to take a look tomorrow. |
|
@BenFradet @fedefernandez This might solve the issues: #117 |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 87.4% 88.17% +0.77%
==========================================
Files 36 36
Lines 516 516
Branches 3 3
==========================================
+ Hits 451 455 +4
+ Misses 65 61 -4
Continue to review full report at Codecov.
|
|
I still have a few unit tests failing, still investigating why |
| request | ||
| .withMethod("GET") | ||
| .withPath(s"/search/issues") | ||
| .withQueryStringParameters(new Parameter("q", s"$nonExistentSearchQuery+")) |
There was a problem hiding this comment.
have you guys tried withQueryStringParameters before?
Never seems to match.
There was a problem hiding this comment.
fixed it with regex 👍
| response should be('left) | ||
| } | ||
|
|
||
| "Issues >> Edit" should "return the edited issue if valid data is provided" ignore { |
There was a problem hiding this comment.
for some reason this one's failing too
There was a problem hiding this comment.
You guys seem to have used post for patch request for the git data API: https://github.com/47deg/github4s/blob/master/github4s/jvm/src/test/scala/github4s/utils/MockGithubApiServer.scala#L328-L348.
So I'm assuming there is something wrong with how mock server deals with patch?
There was a problem hiding this comment.
We should create an issue to fix that part. The root of the problem is the call to postData. In that part the request already has set the PATCH method but if we take a look to this method in scalaj-http we can see that it's setting the method to POST.
One solution could be to replace the postData call by:
-- .postData(body)
++ .postData(d).method(rb.httpVerb.verb)But I've not tested it yet. Sorry about the confusion
There was a problem hiding this comment.
I get it, thanks. I'll log an issue 👍
|
Good to review 👍 |
| .when( | ||
| request | ||
| .withMethod("POST") | ||
| .withPath(s"/repos/$validRepoOwner/$validRepoName/issues") |
There was a problem hiding this comment.
Should it be invalidRepoName?
There was a problem hiding this comment.
true, I don't know how the tests manage to pass 😕
| mockServer | ||
| .when( | ||
| request | ||
| .withMethod("PATCH") |
There was a problem hiding this comment.
I think that our http client is applying a POST method for this operation
There was a problem hiding this comment.
Yup I modified those, the sync doesn't seem to be reflected on gh, weird as well.
| request | ||
| .withMethod("GET") | ||
| .withPath(s"/search/issues") | ||
| .withQueryStringParameters(new Parameter("q", s"$nonExistentSearchQuery+")) |
| .when( | ||
| request | ||
| .withMethod("POST") | ||
| .withPath(s"/repos/$validRepoOwner/$validRepoName/issues") |
There was a problem hiding this comment.
true, I don't know how the tests manage to pass 😕
| mockServer | ||
| .when( | ||
| request | ||
| .withMethod("PATCH") |
There was a problem hiding this comment.
Yup I modified those, the sync doesn't seem to be reflected on gh, weird as well.
|
nvm, pushed to my remote :'( |
on 2.12 |
|
|
Still need to add test cases to
ApiSpec