New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide interpreters with several monad instances #18
Conversation
@@ -3,6 +3,7 @@ description: "A GitHub API wrapper written in Scala" | |||
github_owner: 47deg | |||
baseurl: /github4s | |||
style: github4s | |||
highlight_theme: tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Awesome work! |
Current coverage is 0.68%@@ master #18 diff @@
========================================
Files 15 14 -1
Lines 148 147 -1
Methods 0 0
Messages 0 0
Branches 1 1
========================================
+ Hits 0 1 +1
+ Misses 148 146 -2
Partials 0 0
|
import github4s.free.interpreters.Interpreters | ||
import scala.concurrent.{ ExecutionContext, Future } | ||
|
||
object implicits extends Interpreters with EvalInstances with IdInstances with FutureInstances { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop the braces here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
LGTM |
This PR:
cats.Id
,cats.Eval
,Future
andscalaz.Task
.scalaz
dependency in other module.com.typesafe.config
dependency.@dialelo @raulraja Could you review please? Thank you.