Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide interpreters with several monad instances #18

Merged
merged 9 commits into from Jun 6, 2016

Conversation

rafaparadela
Copy link

This PR:

  • Provides implicit interpreters for cats.Id, cats.Eval, Future and scalaz.Task.
  • Isolates scalaz dependency in other module.
  • Adds examples of use in documentation (tut).
  • Removes com.typesafe.config dependency.

@dialelo @raulraja Could you review please? Thank you.

@@ -3,6 +3,7 @@ description: "A GitHub API wrapper written in Scala"
github_owner: 47deg
baseurl: /github4s
style: github4s
highlight_theme: tomorrow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ghost
Copy link

ghost commented May 30, 2016

Awesome work!

@codecov-io
Copy link

codecov-io commented Jun 6, 2016

Current coverage is 0.68%

Merging #18 into master will increase coverage by 0.68%

@@            master       #18   diff @@
========================================
  Files           15        14     -1   
  Lines          148       147     -1   
  Methods          0         0          
  Messages         0         0          
  Branches         1         1          
========================================
+ Hits             0         1     +1   
+ Misses         148       146     -2   
  Partials         0         0          

Powered by Codecov. Last updated by 63674ae...e24321f

@rafaparadela
Copy link
Author

Comments have been addressed.
@raulraja @dialelo does the code look good to you? Than you.

import github4s.free.interpreters.Interpreters
import scala.concurrent.{ ExecutionContext, Future }

object implicits extends Interpreters with EvalInstances with IdInstances with FutureInstances {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the braces here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ghost
Copy link

ghost commented Jun 6, 2016

:shipit: LGTM

@rafaparadela rafaparadela merged commit 6cc84e9 into master Jun 6, 2016
@rafaparadela rafaparadela deleted the rafa-replace-Id-by-Eval branch June 6, 2016 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants