Make PullRequestFile#patch an Option[String] #181
Conversation
That field is not populated on binary files. Example: curl https://api.github.com/repos/scala/scala/pulls/4877/files | jq '. | map(select(.patch == null))' ```json [ { "sha": "7229603ae5b30ce0e0bd09863543b260085c8f2d", "filename": "src/scaladoc/scala/tools/nsc/doc/html/resource/lib/arrow-down.png", "status": "removed", "additions": 0, "deletions": 0, "changes": 0, "blob_url": "https://github.com/scala/scala/blob/da3720e55b3d69cc31ab0f26e6cffafb18da360f/src/scaladoc/scala/tools/nsc/doc/html/resource/lib/arrow-down.png", "raw_url": "https://github.com/scala/scala/raw/da3720e55b3d69cc31ab0f26e6cffafb18da360f/src/scaladoc/scala/tools/nsc/doc/html/resource/lib/arrow-down.png", "contents_url": "https://api.github.com/repos/scala/scala/contents/src/scaladoc/scala/tools/nsc/doc/html/resource/lib/arrow-down.png?ref=da3720e55b3d69cc31ab0f26e6cffafb18da360f" }, ... ] ```
|
Thanks guys :) I know this is a strange request, but is it at all possible to back-port this ti |
|
Yeah, we are dealing with the same issue here 47degrees/sbt-org-policies#655 No workarounds yet :( |
|
Regarding the build issue, this might fix the issue 47degrees/sbt-microsites#246 |
|
@juanpedromoreno good to know it's a known issue. My current thought is that maybe ideally sbt should be shading its depenencies on Jawn... |
|
It seems the same as I experienced in doobie recently. #182 fixes the build error. |
|
@lloydmeta agreed. It seems you found our attempt to do these changes on the sbt side: |
Closes #180
That field is not populated on binary files.
Example:
$ curl https://api.github.com/repos/scala/scala/pulls/4877/files | jq '. | map(select(.patch == null))'[ { "sha": "7229603ae5b30ce0e0bd09863543b260085c8f2d", "filename": "src/scaladoc/scala/tools/nsc/doc/html/resource/lib/arrow-down.png", "status": "removed", "additions": 0, "deletions": 0, "changes": 0, "blob_url": "https://github.com/scala/scala/blob/da3720e55b3d69cc31ab0f26e6cffafb18da360f/src/scaladoc/scala/tools/nsc/doc/html/resource/lib/arrow-down.png", "raw_url": "https://github.com/scala/scala/raw/da3720e55b3d69cc31ab0f26e6cffafb18da360f/src/scaladoc/scala/tools/nsc/doc/html/resource/lib/arrow-down.png", "contents_url": "https://api.github.com/repos/scala/scala/contents/src/scaladoc/scala/tools/nsc/doc/html/resource/lib/arrow-down.png?ref=da3720e55b3d69cc31ab0f26e6cffafb18da360f" }, ... ]