add get tree api implementation

[aberey]

Implemented missing parts of the Git Tree API:

https://developer.github.com/v3/git/trees/#get-a-tree

[fedefernandez]

Hi @aberey, thanks for your contribution. Do you mind to add a new integration test here. There isn't a spec for trees because we avoid the write operations in the integration tests, but you could add the one for getting the tree.

See the one for pull request as an example:

https://github.com/47deg/github4s/blob/3c9b0985276d504230ab031c05917593f38069df/github4s/shared/src/test/scala/github4s/integration/GHPullRequestsSpec.scala#L27-L54

Thanks

[aberey]

Hi @fedefernandez - as requested, I have added some integration tests. Best regards!

[BenFradet]

Thanks 👍

[fedefernandez]

Left some minor comments, the code looks great. Thanks!

[fedefernandez]

Could you please add the recursive param to the scaladoc?
Also, please, add spaces after and before of the = sign (recursive: Boolean = false)

[fedefernandez]

-- truncated: Option[Boolean]=None
++ truncated: Option[Boolean] = None

[aberey]

Thanks for the feedback - fixed the spacing/documentation issues. Cheers!

[BenFradet]

hey @aberey ,

The tests are failing:

[info] - should return the file tree recursively *** FAILED ***
[info]   List(".gitignore", "build.sbt", "project") was not equal to List(".gitignore", "build.sbt", "project", "project/build.properties", "project/plugins.sbt") (GHGitDataSpec.scala:98)

[info] GitData.getTree
[info] - should call to httpClient.get with the right parameters *** FAILED ***
[info]   Unexpected call: <mock-7> HttpClientTest.get[A](Some(token), repos/47deg/github4s/git/trees/d3b048c1f500ee5450e5d7b3d1921ed3e7645891, Map(user-agent -> github4s), Map(), None, io.circe.generic.decoding.DerivedDecoder$$anon$1@1f)
[info]   
[info]   Expected:
[info]   inAnyOrder {
[info]     <mock-7> HttpClientTest.get[A](Some(token), repos/47deg/github4s/git/trees/d3b048c1f500ee5450e5d7b3d1921ed3e7645891?recursive=1, Map(user-agent -> github4s), Map(), *, *) once (never called - UNSATISFIED)
[info]   }
[info]   
[info]   Actual:
[info]     <mock-7> HttpClientTest.get[A](Some(token), repos/47deg/github4s/git/trees/d3b048c1f500ee5450e5d7b3d1921ed3e7645891, Map(user-agent -> github4s), Map(), None, io.circe.generic.decoding.DerivedDecoder$$anon$1@1f) (github4s-test-fastopt.js:40344)

[aberey]

@BenFradet I'm sorry, apparently I had some sbt cache issues, which I resolved now. Actually it turned out I was not setting the url parameter via the appropriate API, which I fixed now as well. I double-checked the tests are passing successfully in my local environment.

[BenFradet]

Thanks, merging 👍