Make the integration tests skippable #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool! I'd be happy to try this out in the community build once it's merged here. (or, I could try it out first, if you'd like.) |
|
I ran the tests locally without a token and it seemed to work but it'd be great to confirm it meets your expectations 👍 |
fedefernandez
approved these changes
Apr 11, 2019
There was a problem hiding this comment.
I didn't know about this scalatest Tag feature, looks neat. Thanks for addressing this issue @BenFradet. LGTM if meets the expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some unit tests in
ApiSpecrelying on the token being present so I ignored those as wellcc @SethTisue