New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding merge_commit_sha field to PullRequest model #260
Adding merge_commit_sha field to PullRequest model #260
Conversation
@jdesiloniz I guess we need to disable that option for scala 2.11, something like: scalacOptions ++= (scalaBinaryVersion.value match {
case x if x.startsWith("2.12") => Seq("-Ywarn-macros:after")
case _ => Seq.empty
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, aside from the compilation problems (that seem to be solved?)
project/ProjectPlugin.scala
Outdated
@@ -124,6 +124,10 @@ object ProjectPlugin extends AutoPlugin { | |||
scalaVersion := V.scala212, | |||
crossScalaVersions := Seq(V.scala211, V.scala212), | |||
scalacOptions ~= (_ filterNot Set("-Xlint").contains), | |||
scalacOptions ++= ((scalaBinaryVersion.value, getEnvVar("SCALAENV")) match { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bilki I've just launched a new build process in Travis without these, to verify if the stack size fix did the trick by itself... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bilki yup, that did the trick! Thanks for the suggestion!!
version.sbt
Outdated
version in ThisBuild := "0.20.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to release now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bilki I'm holding back from this, so we can decide the release timeline appropiatedly in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retroactive approval, looks good to me
This PR adds the
merge_commit_sha
to thePullRequest
model. According to the GitHub API docs:This field can be really useful for creating and updating statuses by targetting the test commit sha instead of the latest one in a PR.