Find and replace unicode arrows #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Seeing the following in the CI logs if anyone can advise? - |
BenFradet
reviewed
Nov 28, 2019
| response.toOption map { r ⇒ | ||
| r.result.isEmpty shouldBe true | ||
| r.statusCode shouldBe okStatusCode | ||
| } |
There was a problem hiding this comment.
this works on master, can you rebase or if it's already done leave it as is?
There was a problem hiding this comment.
Yes, sure thing
There was a problem hiding this comment.
@BenFradet
When I checkout this main repo and run sbt validateJVM it fails
$ git clone git@github.com:47deg/github4s.git
$ cd github4s/
$ sbt validateJVM
# ...
[info] - should return an empty list when an invalid ref is passed *** FAILED ***
[info] Left(github4s.GithubResponses$UnsuccessfulHttpRequest: Failed invoking with status : 404 body :
[info] ) was not right (ApiSpec.scala:406)
# ...
[info] Tests: succeeded 229, failed 1, canceled 0, ignored 101, pending 0
[info] *** 1 TEST FAILED ***
[error] Failed tests:
[error] github4s.unit.ApiSpec
[error] (Test / test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 60 s, completed Nov 28, 2019, 1:06:14 PM
There was a problem hiding this comment.
this test is very flaky, it works for me locally and on travis in master
There was a problem hiding this comment.
logged #300 in this regard
| @@ -80,8 +80,8 @@ class HttpRequestBuilder[C, M[_]]( | |||
|
|
|||
| def withAuth(accessToken: Option[String] = None) = { | |||
| val authHeader = accessToken match { | |||
| case Some(token) ⇒ Map("Authorization" → s"token $token") | |||
| case _ ⇒ Map.empty[String, String] | |||
| case Some(token) => Map("Authorization" → s"token $token") | |||
There was a problem hiding this comment.
should we to take care of → as well? maybe in a separate PR
There was a problem hiding this comment.
Was planning on a separate PR, i'll get a ticket started! Thanks
fedefernandez
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.