Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagged test as integration #301

Merged

Conversation

duanebester
Copy link
Contributor

I found that setting the GITHUB4S_ACCESS_TOKEN allows the test to pass and not having it makes it fail, so I tagged the test as Integration

#300

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent find 👍

@BenFradet BenFradet merged commit 8a0e4e0 into 47degrees:master Dec 2, 2019
@fedefernandez
Copy link
Contributor

@duanebester sorry I've been a bit out of this, could you please explain to me why this is working? Are those tests executed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants