Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates sbt-catalysts-extras and sbt-microsites plugins #35

Merged
merged 3 commits into from Oct 24, 2016

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno commented Oct 22, 2016

This PR Integrates sbt catalysts extras plugin, but also:

  • Replaces the old microsite style with sbt-microsites plugin
  • Replaces Scalariform by Scalafmt
  • Adds file headers license through sbt-header plugin
  • Changes the settings according the new integrated plugin (https://github.com/47deg/sbt-catalysts-extras)
  • Prepares the library to make the first release to maven central (0.8.1).

Please, @raulraja could you review? Thanks!

@codecov-io
Copy link

codecov-io commented Oct 22, 2016

Current coverage is 86.59% (diff: 84.79%)

Merging #35 into master will decrease coverage by 0.41%

@@             master        #35   diff @@
==========================================
  Files            16         16          
  Lines           254        261     +7   
  Methods         252        259     +7   
  Messages          0          0          
  Branches          2          2          
==========================================
+ Hits            221        226     +5   
- Misses           33         35     +2   
  Partials          0          0          

Powered by Codecov. Last update 22f5373...838a2b2

@raulraja
Copy link
Contributor

LGTM but @rafaparadela may be better suited to review this.

@rafaparadela
Copy link

LGTM

Copy link

@rafaparadela rafaparadela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM Thanks

@juanpedromoreno juanpedromoreno merged commit f6b99e2 into master Oct 24, 2016
@juanpedromoreno juanpedromoreno deleted the integrates-sbt-catalysts-extras-plugin branch October 24, 2016 08:54
@rafaparadela
Copy link

I will review it as soon as I get the office. It seems to include great
improvements. Thanks Juanpe.
On Sun, 23 Oct 2016 at 22:17, Raúl Raja Martínez notifications@github.com
wrote:

LGTM but @rafaparadela https://github.com/rafaparadela may be better
suited to review this.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#35 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATOvt3g68e7EG7WM5UOInThLGBtMqcHks5q28DFgaJpZM4Kd_cu
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants