Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List milestone and List Labels in a project #359

Merged
merged 15 commits into from Mar 5, 2020
Merged

Conversation

anamariamv
Copy link
Contributor

This PR solves #341 and #340

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #359 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   92.27%   92.39%   +0.11%     
==========================================
  Files          24       24              
  Lines         518      526       +8     
  Branches        1        0       -1     
==========================================
+ Hits          478      486       +8     
  Misses         40       40
Impacted Files Coverage Δ
github4s/src/main/scala/github4s/Decoders.scala 90.83% <100%> (+0.07%) ⬆️
...cala/github4s/interpreters/IssuesInterpreter.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f1f71...900cded. Read the comment docs.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , just minor comments

Copy link
Contributor

@bond15 bond15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ben's comments covered mine.

@anamariamv anamariamv merged commit db70e5b into master Mar 5, 2020
@anamariamv anamariamv deleted the am-340-ListLabels branch March 5, 2020 12:23
@juanpedromoreno juanpedromoreno mentioned this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants