Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List cards #364

Merged
merged 9 commits into from Mar 13, 2020
Merged

List cards #364

merged 9 commits into from Mar 13, 2020

Conversation

bond15
Copy link
Contributor

@bond15 bond15 commented Mar 9, 2020

Adds the functionality to list cards in a project by column id.

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #364 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   92.64%   92.81%   +0.17%     
==========================================
  Files          23       23              
  Lines         530      543      +13     
  Branches        1        1              
==========================================
+ Hits          491      504      +13     
  Misses         39       39
Impacted Files Coverage Δ
...la/github4s/interpreters/ProjectsInterpreter.scala 100% <100%> (ø) ⬆️
github4s/src/main/scala/github4s/Decoders.scala 90.9% <100%> (+0.06%) ⬆️
.../scala/github4s/interpreters/AuthInterpreter.scala 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2728553...31a21d4. Read the comment docs.

Copy link
Contributor

@anamariamv anamariamv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/docs/project.md Show resolved Hide resolved
docs/docs/project.md Outdated Show resolved Hide resolved
@bond15
Copy link
Contributor Author

bond15 commented Mar 12, 2020

I think we may be triggering at 403 in the integrations tests by giving the wrong credentials too many times to the Auth api.

https://developer.github.com/v3/#authentication

Also, the integrations tests are sensitive to the remove label test. Not sure if this is a race condition between creating a label and then deleting it immediately.

docs/docs/project.md Outdated Show resolved Hide resolved
@BenFradet BenFradet merged commit e1233d1 into master Mar 13, 2020
@BenFradet BenFradet deleted the list-cards branch March 13, 2020 10:17
@juanpedromoreno juanpedromoreno mentioned this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate a new API: Get the list of cards for a project (given a column id)
4 participants