Migrates from 47deg to 47degrees GH organization #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenFradet
reviewed
Mar 13, 2020
docs/docs/activity.md
Outdated
| @@ -70,7 +70,7 @@ You can list the users starring a specific repository with `listStargazers`; it | |||
| - `timeline`: whether or not to return the date at which point the user starred the repository. | |||
| - `pagination`: Limit and Offset for pagination, optional. | |||
|
|
|||
| To list the stargazers of 47deg/github4s: | |||
| To list the stargazers of 47degrees/github4s: | |||
|
|
|||
| ```scala mdoc:compile-only | |||
| val listStargazers = Github[IO](accessToken).activities.listStargazers("47deg", "github4s", true) | |||
There was a problem hiding this comment.
do we need to modify the examples too?
|
it might be that the token needs updating? |
|
The token was updated, the problem is that the test data was pointing to the old organization. Now it's fixed and ready for review :) |
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 86.16% 92.71% +6.54%
==========================================
Files 23 23
Lines 535 535
Branches 1 1
==========================================
+ Hits 461 496 +35
+ Misses 74 39 -35
Continue to review full report at Codecov.
|
rafaparadela
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.