API: Create milestone #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 25, 2020 17:29
BenFradet
approved these changes
Mar 26, 2020
| @@ -314,4 +314,24 @@ trait Issues[F[_]] { | |||
| headers: Map[String, String] = Map() | |||
| ): F[GHResponse[List[Milestone]]] | |||
|
|
|||
| /** | |||
| * | |||
| title: String, | ||
| state: Option[String], | ||
| description: Option[String], | ||
| due_on: Option[String], |
There was a problem hiding this comment.
I wonder if in these cases it wouldn't be better to supply a value of type date and format it ourselves, wdyt? 🤔
There was a problem hiding this comment.
Yes, I agree, it looks like we'll need a ZonedDateTime
added 2 commits
March 27, 2020 12:08
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
===========================================
+ Coverage 78.71% 92.72% +14.00%
===========================================
Files 23 23
Lines 531 536 +5
Branches 2 2
===========================================
+ Hits 418 497 +79
+ Misses 113 39 -74
Continue to review full report at Codecov.
|
juanpedromoreno
approved these changes
Mar 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement https://developer.github.com/v3/issues/milestones/#create-a-milestone