Updated and delete milestone #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
approved these changes
Mar 30, 2020
BenFradet
approved these changes
Mar 30, 2020
docs/docs/issue.md
Outdated
| } | ||
| ``` | ||
|
|
||
| The `result` on the right is the corresponding [Milestone][milestone-scala] |
Co-Authored-By: Juan Pedro Moreno <4879373+juanpedromoreno@users.noreply.github.com>
| @@ -232,4 +232,28 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio | |||
| headers, | |||
| MilestoneData(title, state, description, due_on) | |||
| ) | |||
|
|
|||
| override def updatedMilestone( | |||
There was a problem hiding this comment.
updateMilestone for consistency?
juanpedromoreno
approved these changes
Mar 31, 2020
added 2 commits
March 31, 2020 12:31
# Conflicts: # docs/docs/issue.md # github4s/src/main/scala/github4s/algebras/Issues.scala # github4s/src/main/scala/github4s/interpreters/IssuesInterpreter.scala # github4s/src/test/scala/github4s/unit/IssuesSpec.scala # github4s/src/test/scala/github4s/utils/TestData.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement: