Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new root project to set Scala version #50

Merged
merged 1 commit into from Jan 5, 2017

Conversation

fedefernandez
Copy link
Contributor

This PR adds a new root project in order to define the Scala version

Scala formatter has formatted some configuration files, but the only change is:

lazy val root = (project in file("."))
  .settings(buildSettings: _*)
  .aggregate(github4sJVM, github4sJS, scalaz, docs)

Please @juanpedromoreno could you review? Thanks

@codecov-io
Copy link

Current coverage is 85.82% (diff: 100%)

Merging #50 into master will not change coverage

@@             master        #50   diff @@
==========================================
  Files            27         27          
  Lines           402        402          
  Methods         398        398          
  Messages          0          0          
  Branches          3          3          
==========================================
  Hits            345        345          
  Misses           57         57          
  Partials          0          0          

Powered by Codecov. Last update 55f171d...d36e566

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fedefernandez fedefernandez merged commit 045ffd7 into master Jan 5, 2017
@fedefernandez fedefernandez deleted the adds-root-package branch January 5, 2017 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants