New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default value #553
Added default value #553
Conversation
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
===========================================
- Coverage 91.24% 77.41% -13.83%
===========================================
Files 24 24
Lines 651 651
Branches 1 0 -1
===========================================
- Hits 594 504 -90
- Misses 57 147 +90
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for my comment 👍
Hi @BenFradet, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, thanks 👍
Hi guys,
Close #549.
Btw, some
Option
field already hasNone
values. So It was mess. Some addOption
only, someOption = None
.Also close #526 by added