Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default value #553

Merged
merged 3 commits into from Sep 23, 2020
Merged

Conversation

loonydev
Copy link
Contributor

@loonydev loonydev commented Sep 22, 2020

Hi guys,
Close #549.
Btw, some Option field already has None values. So It was mess. Some add Option only, some Option = None.

Also close #526 by added

final case class Repository(
    ...
    permissions: Option[RepoPermissions] = None
)

final case class RepoPermissions(
    admin: Boolean,
    push: Boolean,
    pull: Boolean
)

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #553 into master will decrease coverage by 13.82%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #553       +/-   ##
===========================================
- Coverage   91.24%   77.41%   -13.83%     
===========================================
  Files          24       24               
  Lines         651      651               
  Branches        1        0        -1     
===========================================
- Hits          594      504       -90     
- Misses         57      147       +90     
Impacted Files Coverage Δ
...s/src/main/scala/github4s/domain/PullRequest.scala 0.00% <ø> (-100.00%) ⬇️
...4s/src/main/scala/github4s/domain/Repository.scala 100.00% <ø> (ø)
github4s/src/main/scala/github4s/Decoders.scala 84.44% <100.00%> (-6.67%) ⬇️
...ala/github4s/interpreters/GitDataInterpreter.scala 100.00% <100.00%> (ø)
...cala/github4s/interpreters/IssuesInterpreter.scala 100.00% <100.00%> (ø)
github4s/src/main/scala/github4s/Github.scala 0.00% <0.00%> (-100.00%) ⬇️
...ithub4s/src/main/scala/github4s/GithubConfig.scala 0.00% <0.00%> (-100.00%) ⬇️
...4s/src/main/scala/github4s/http/Http4sSyntax.scala 0.00% <0.00%> (-100.00%) ⬇️
...s/src/main/scala/github4s/modules/GithubAPIs.scala 0.00% <0.00%> (-100.00%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afde993...fb57595. Read the comment docs.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for my comment 👍

github4s/src/main/scala/github4s/domain/Issue.scala Outdated Show resolved Hide resolved
@loonydev
Copy link
Contributor Author

Hi @BenFradet,
Do I need something else here?

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, thanks 👍

@BenFradet BenFradet merged commit 53b6f32 into 47degrees:master Sep 23, 2020
@loonydev loonydev deleted the 549-default-option-value branch September 24, 2020 05:54
@juanpedromoreno juanpedromoreno added the breaking-change A breaking change that needs to be treated with consideration label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change that needs to be treated with consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value for optional field Include "permissions" in domain objects
3 participants