Adds some git methods #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 79.1% 79.43% +0.32%
==========================================
Files 27 31 +4
Lines 402 457 +55
Branches 2 2
==========================================
+ Hits 318 363 +45
- Misses 84 94 +10
Continue to review full report at Codecov.
|
juanpedromoreno
approved these changes
Mar 28, 2017
| } | ||
| } | ||
|
|
||
| it should "return the multiple reference" in { |
There was a problem hiding this comment.
"return multiple references"?
| implicit def decodeListRef(implicit D: Decoder[Ref]): Decoder[NonEmptyList[Ref]] = { | ||
|
|
||
| def decodeCursor(partialList: Option[NonEmptyList[Ref]], cursor: HCursor): Decoder.Result[NonEmptyList[Ref]] = | ||
| cursor.as[Ref] match { |
| } | ||
|
|
||
| Decoder.instance { c ⇒ | ||
| c.as[Ref] match { |
There was a problem hiding this comment.
It's not possible because the left function result is encapsulated inside a Left in the bimap and we want to return an Either
* Refactorizes the Git ops to GitData * Adds new tests for Git ops * Disables minimum coverage for scalaz and js modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some needed
gitmethods for adding new content to a GitHub repo.Please @juanpedromoreno, could you review? Thanks