Fixes BuildInfo Code Dependency #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
force-pushed
the
jp-fixes-build-info-code-dep
branch
from
dd16d1c
to
3688b2c
Compare
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 79.75% 80.24% +0.48%
==========================================
Files 35 35
Lines 499 496 -3
Branches 3 2 -1
==========================================
Hits 398 398
+ Misses 101 98 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an unneeded code dependency with BuildInfo object, which is not being exported, and consequently it's an issue for JS clients that are using
github4s.Please, @fedefernandez @jdesiloniz could you review? Thanks!