Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tries to fix OOM issues. Bumps sbt version #92

Merged
merged 11 commits into from Apr 24, 2017

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno commented Apr 21, 2017

Fixes #84

Please, @fedefernandez could you review? Thanks!

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files          36       36           
  Lines         512      512           
  Branches        2        2           
=======================================
  Hits          449      449           
  Misses         63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9291aac...422905f. Read the comment docs.

@juanpedromoreno
Copy link
Member Author

@fedefernandez Some commits have been pushed after your LGTM, do you mind to do another quick review? Thanks!

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juanpedromoreno juanpedromoreno merged commit 9f7a028 into master Apr 24, 2017
@juanpedromoreno juanpedromoreno deleted the tries-to-fix-oom-issues branch April 24, 2017 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants