Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output file #13

Merged
merged 5 commits into from
Feb 18, 2019
Merged

Output file #13

merged 5 commits into from
Feb 18, 2019

Conversation

AdrianRaFo
Copy link
Contributor

Add the ability to send the output to a local file.
Also, fix several issues and binary incompatibilities

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@AdrianRaFo AdrianRaFo merged commit 1becc58 into arf-commit-integration Feb 18, 2019
@AdrianRaFo AdrianRaFo deleted the arf-output-file branch February 18, 2019 18:41
AdrianRaFo added a commit that referenced this pull request Feb 19, 2019
* wip add commit support

* restructure, clean up and upload task

* finish upload task and create or update files

* specify location as a separate parameter

* update doc

* fix token param

* Output file (#13)

* send output to file

* delete no need dep

* fix file generation

* solve errors and bin issues

* minor improvements and format suggestions

* Update README.md

Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>

* Update src/main/kotlin/com/fortysevendeg/hood/github/GithubCommentIntegration.kt

Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>

* Update src/main/kotlin/com/fortysevendeg/hood/github/GithubCommentIntegration.kt

Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>

* Update src/main/kotlin/com/fortysevendeg/hood/github/GithubCommentIntegration.kt

Co-Authored-By: AdrianRaFo <15971742+AdrianRaFo@users.noreply.github.com>

* code cleanup

* syntax improvement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants