Support oneof fields #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't skip writing a oneof field even if it has a default scalar value. The implementation for this is a bit nasty. I added a boolean parameter to the signature of `PBFieldWriter` that is only used when writing a scalar field and is ignored in all other cases. Will have a think about a cleaner solution.
This is so we can set the field to None when it is missing when reading a message from protobuf. If it was a plain coproduct type (e.g. `Int :+: String :+: CNil`), there is no sensible default value we can set it to. We could arbitrarily set it to `Inr(0)`, but we would lose the information that the field was missing from the message.
juanpedromoreno
approved these changes
Dec 27, 2019
| gen: Generic.Aux[A, R], | ||
| repr: Lazy[PBMessageReader[R]]): PBMessageReader[A] = instance { (bytes: Array[Byte]) => | ||
| gen.from(repr.value.read(bytes)) | ||
| } |
cb372
added a commit
to higherkindness/skeuomorph
that referenced
this pull request
Jan 2, 2020
This is for compatibility with pbdirect. See 47degrees/pbdirect#30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for reading/writing shapeless coproducts as protobuf
oneoffields.The field must be annotated with a
@pbIndexannotation containing the field numbers for each branch of the coproduct. Also the coproduct type must be wrapped inOptionso that we can handle missing fields sensibly.e.g.
Also updated the readme to document both this feature and the new support for default values/missing fields.
This PR also removes a feature that I didn't think should exist: reading and writing sealed traits of messages, e.g.
The same functionality can now be achieved more safely and protobuf-compliantly using a
oneoffield.