Support signed/unsigned/fixed-width integers #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Define tags * Add PBScalarValueReader/Writers for tagged Int/Long types * Write unit tests and extend the property-based tests * Document the feature in the README
cb372
force-pushed
the
signed-unsigned-fixed-integers
branch
from
293783d
to
276bbd9
Compare
cb372
changed the title
fedefernandez
approved these changes
Jan 10, 2020
| @@ -78,6 +79,16 @@ trait LowPriorityPBScalarValueWriterImplicits { | |||
|
|
|||
| trait PBScalarValueWriterImplicits extends LowPriorityPBScalarValueWriterImplicits { | |||
|
|
|||
| implicit object ContravariantWriter extends Contravariant[PBScalarValueWriter] { | |||
| override def canBePacked: Boolean = true | ||
| override def read(input: CodedInputStream): Int @@ Unsigned = | ||
| tag[Unsigned](input.readUInt32()) | ||
| } |
There was a problem hiding this comment.
Wondering if we could have some object or abstract class that would receive the types and the function and will create the PBScalarValueReader for us
def apply[A, B](read: CodedInputstream => A): PBScalarValueReader[A @@ B] = ???
BenFradet
approved these changes
Jan 13, 2020
juanpedromoreno
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support signed/unsigned/fixed-width integers via tagged types
Signed,Unsigned,FixedtagsInitially I planned to implement this using annotations on fields, e.g.
@pbFixed, but it didn't really work. e.g. the following two examples would be impossible to encode in Scala using field annotations: